Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 3c1f64f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 17 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
- Show Via and Access only once the role audience has loaded, and hide the default plugin's route from non-admins. - Refresh the role audience after saving plugin membership. - Open the membership table in a popover so keyboard users reach the role links. - Move ClientIconFan to a shared component. - Restore a test for the unproxied server overview.
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RoleLink, and Access is in mono. A plugin with several routes gets one row per route. People who aren't org admins can't see role matches, so their Via and Access show "—".Motivation
The one-line status lost the banner's context and controls. The old subtitle was the only place that explained how a server got into each plugin, through which role and with what access, and that matters. With several role plugins it ran to a paragraph, so this PR moves it into a table behind the count.
Gutternote review steps
/<org>/projects/<project>/mcp/<server>) → Overview. You need the plugin edit permission, and an org admin role to see role matches.Also check: a server in no plugin (amber "Not published to any plugin" with the explainer), a narrow viewport (the artwork hides), and dark mode.
Summary by cubic
Restores the MCP server Overview plugin banner, which #9215 had reduced to a one-line status, and moves membership details into a table behind the "Published to N plugins" headline.
PluginDistributionLineand folds its logic intoPluginStatusBanner, which now serves both the banner and settings variants.Written for commit 3c1f64f. Summary will update on new commits.
🚀 Preview Environment (PR #9291)
Preview URL: https://pr-9291.dev.getgram.ai
Gram Preview Bot