Skip to content

feat: bring back the MCP overview plugin banner with a membership table - #9291

Open
adaam2 wants to merge 3 commits into
mainfrom
adaam2/mcp-overview-perf-banner-ee19cb64
Open

adaam2 wants to merge 3 commits into
mainfrom
adaam2/mcp-overview-perf-banner-ee19cb64

Conversation

@adaam2

@adaam2 adaam2 commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

Summary

  • MCP server Overview: brings back the plugin banner that feat: slim the MCP overview plugin card to a one-line status and add View logs #9215 replaced with a one-line status. The banner is restored as it was: the plugin picker, Publish, the Install section, and the client artwork.
  • Membership detail: the long "X · via role Y, which can use all servers, …" subtitle is gone. The headline now reads "Published to N plugins ⓘ". Hovering over it opens a table with Plugin | Via | Access. Via links each role to its edit page through RoleLink, and Access is in mono. A plugin with several routes gets one row per route. People who aren't org admins can't see role matches, so their Via and Access show "—".
  • Settings → Plugins tile: shows the same client artwork on the right.
  • Kept from feat: slim the MCP overview plugin card to a one-line status and add View logs #9215: the View logs button next to the time range.

Motivation

The one-line status lost the banner's context and controls. The old subtitle was the only place that explained how a server got into each plugin, through which role and with what access, and that matters. With several role plugins it ran to a paragraph, so this PR moves it into a table behind the count.

Gutternote review steps

  1. Sidebar → MCP → open any MCP server (/<org>/projects/<project>/mcp/<server>) → Overview. You need the plugin edit permission, and an org admin role to see role matches.
  2. If the server is in plugins, the banner at the top reads "Published to N plugins ⓘ", with the picker, Update, and the Install the plugin section below it.
  3. Hover over "N plugins". The table lists each plugin, the role it came through as a link, and the access in mono. Move onto a role name and click it: the role's edit page opens.
  4. Open Settings → Plugins. The client artwork sits on the right of the tile.

Also check: a server in no plugin (amber "Not published to any plugin" with the explainer), a narrow viewport (the artwork hides), and dark mode.


Summary by cubic

Restores the MCP server Overview plugin banner, which #9215 had reduced to a one-line status, and moves membership details into a table behind the "Published to N plugins" headline.

  • The banner brings back the plugin picker, Publish, the Install section, and client artwork; the View logs button from feat: slim the MCP overview plugin card to a one-line status and add View logs #9215 stays.
  • Hovering or focusing the count opens a popover table with Plugin | Via | Access columns; Via links each role to its edit page, and Access shows the grant in mono.
  • Role matches are only shown to org admins and only after they load, so other users see "—" in Via and Access.
  • The Settings → Plugins tile shows the same client artwork.
  • Removes PluginDistributionLine and folds its logic into PluginStatusBanner, which now serves both the banner and settings variants.

Written for commit 3c1f64f. Summary will update on new commits.

View guided diff Turn on auto-fix


🚀 Preview Environment (PR #9291)

Preview URL: https://pr-9291.dev.getgram.ai

Component Status Details Updated (UTC)
❌ Database Behind main Rebase onto main: branch lacks migration(s) 20261119213323 2026-11-22 04:19:24.
✅ Images Available Container images ready 2026-11-22 04:20:21.

Gram Preview Bot

@adaam2 adaam2 added the enhancement New feature or request label Nov 19, 2026
@adaam2
adaam2 marked this pull request as ready for review November 19, 2026 13:05
@adaam2
adaam2 requested review from a team as code owners November 19, 2026 13:05
@changeset-bot

changeset-bot Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 3c1f64f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions Bot added the preview Spawn a preview environment label Nov 19, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 17 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

- Show Via and Access only once the role audience has loaded, and hide the
  default plugin's route from non-admins.
- Refresh the role audience after saving plugin membership.
- Open the membership table in a popover so keyboard users reach the role links.
- Move ClientIconFan to a shared component.
- Restore a test for the unproxied server overview.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request preview Spawn a preview environment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant